-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regex filtering #806
Add regex filtering #806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wrorks!
8086431
to
dd0e8a3
Compare
@imwints Looks good! But should do some performance testing on how the filtering behaves before and after. Should likely be faster, but you never know. |
Filters starting with '!' will try to match processes pid, name, cmd and user with extended regex as defined by the C++ standard. A single '!' will not filter.
The regex search will likely slow things down a lot. But since the regex matching is only performed with the leading '!' I'm pretty sure the normal search is not impacted. |
Ah, right :) Nice work! |
Here is just a simple comparison without any context... |
@imwints |
how use this feature, I try !chrome but the result does not show all processes other than chrome |
Filters starting with '!' will try to match processes pid, name, cmd and user with extended regex as defined by the C++ standard. A single '!' will not filter.
Partially implements #387, but is missing the option to filter by type, meaning by user or command only.